MyBB Hacks

(01-02-2011 06:41 AM)PK8 Wrote: [ -> ]I just got an idea for XThreads. It kind of came about when I was making an extra thread field. I'm not sure if it's already possible or if it might seem like a silly idea but how about thread field-dependent thread fields? Like... thread fields that would appear when certain options from other thread fields are selected. ...

// connect to DB
	define('TABLE_PREFIX', $config['database']['table_prefix']);
	$db->connect($config['database']);
	$db->set_table_prefix(TABLE_PREFIX);
	$db->type = $config['database']['type'];
// Stuff added by me
	$result = mysql_query("SELECT tid , uid FROM mybb_xtattachments WHERE aid=".$aid);
	$attachment = mysql_fetch_assoc($result);
	$threadid = $attachment['tid'];
	$postuserid = $attachment['uid'];
//end of first bit of my stuff
	
	// so we do all the above just to run an update query :P

<-- my query goes here -->
}
	$db->write_query('UPDATE '.$db->table_prefix.'xtattachments SET downloads=downloads+1 WHERE aid='.intval($aid), 1);


	$db->close();
	unset($db, $GLOBALS['mybb']);
}

I would prefer to NOT have to change the XThreads files with core edits like this, but I don't know much about hooks.

Also, I am not sure if its my install, but in the xtattchments table in the db all the user ids are 0?

Hmm, I see this in uploads_php

// note, $uid is used purely for flood checking; not verification, identification or anything else
function &upload_xtattachment(&$attachment, &$tf, $uid, $update_attachment=0, $tid=0)

So I guess its not my install - I am on version 1.337 though. (Looks hopeful for 1.4)

(01-02-2011 06:41 AM)PK8 Wrote: [ -> ]I just got an idea for XThreads. It kind of came about when I was making an extra thread field. I'm not sure if it's already possible or if it might seem like a silly idea but how about thread field-dependent thread fields? Like... thread fields that would appear when certain options from other thread fields are selected.

(01-02-2011 06:41 AM)PK8 Wrote: [ -> ]Edit 2 (4:17pm est): I just got another idea which is sort of based on a vBulletin plugin I used to use for a vB forum. Would it be possible to tag selected threads with thread field options via Inline Moderation?

(01-02-2011 10:44 AM)leefish Wrote: [ -> ]I would prefer to NOT have to change the XThreads files with core edits like this, but I don't know much about hooks.

(01-02-2011 10:44 AM)leefish Wrote: [ -> ]Also, I am not sure if its my install, but in the xtattchments table in the db all the user ids are 0?

UPDATE mybb_xtattachments a INNER JOIN mybb_threads t ON a.tid=t.tid SET a.uid=t.uid WHERE a.uid=0 AND a.tid!=0

(01-04-2011 06:02 PM)ZiNgA BuRgA Wrote: [ -> ]

(01-02-2011 10:44 AM)leefish Wrote: [ -> ]I would prefer to NOT have to change the XThreads files with core edits like this, but I don't know much about hooks.

Unfortunately xthreads_attach.php doesn't have any hooks.  I might provide an option to enable them when I make a better plugin API for XThreads, but otherwise, xthreads_attach.php was designed to be as lightweight as possible, so it tries to avoid loading unnecessary stuff (including plugins).

So your only option is to stick with the code edit.  That section of code is unlikely going to change, so if you like using GNU diff/patch, that'll work too (if not, don't worry about it).

(01-04-2011 06:02 PM)ZiNgA BuRgA Wrote: [ -> ]

(01-02-2011 10:44 AM)leefish Wrote: [ -> ]Also, I am not sure if its my install, but in the xtattchments table in the db all the user ids are 0?

It's a known bug, which won't be there in v1.40.
If you want to patch it, just apply this one change to inc/xt_upload.php https://github.com/zingaburga/XThreads-M...https://github.com/zingaburga/XThreads-MyBB-Plugin/commit/90317bec0c0b8ad531603a668982a97cfde77
It doesn't actually really affect XThreads behavior much, but it might for other plugins that decide to rely on it.
You can try fixing existing data with the following query:

SQL Code

UPDATE mybb_xtattachments a INNER JOIN mybb_threads t ON a.tid=t.tid SET a.uid=t.uid WHERE a.uid=0 AND a.tid!=0

---