MyBB 1.8

[RateU]

MyBB 1.8 still uses this query in forumdisplay.php like MyBB 1.6?

PHP Code:

613 614 615 616 617 618 619

$query = $db->simple_select("forums", "threads, unapprovedthreads, deletedthreads", "fid = '{$fid}'", array('limit' => 1)); $forum_threads = $db->fetch_array($query); $threadcount = $forum_threads['threads']; if($ismod == true) { $threadcount += $forum_threads['unapprovedthreads'] + $forum_threads['deletedthreads']; }

---

[nier3]

Yes, I have this exact code in line 613 on Mybb 1.8.5

I'm afraid upgrade to 1.8.6, many users with problems, so stop suicide missions on MyBB for me lol

[RateU]

I think MyBB should change the query since 1.8 has prefix filter feature in forumdisplay.

[Sama34]

1.6 https://github.com/mybb/mybb/blob/master...https://github.com/mybb/mybb/blob/master/forumdisplay.php

1.8 https://github.com/mybb/mybb/blob/featur...https://github.com/mybb/mybb/blob/feature/forumdisplay.php

You meant $prefixsql should be used in the query?

[RateU]

Yep. I think it should uses the previous query (the query which count threads by using threads table) if $prefixsql has a value.

Also, you may interest to this lines in showthread.php

PHP Code:

369 370 371 372 373 374 375 376

$query = $db->simple_select("forums", "threads, unapprovedthreads", "fid = '{$fid}'", array('limit' => 1)); $forum_threads = $db->fetch_array($query); $threadcount = $forum_threads['threads']; if(is_moderator($fid, "canviewunapprove") == true) { $threadcount += $forum_threads['unapprovedthreads']; }

---