Threaded Mode | Linear Mode

Sama34 · 11-30-2012 07:44 PM

(11-26-2012 04:04 PM)ZiNgA BuRgA Wrote: Having the same description as the title really doesn't help people understand what you mean...

Bug. Language variables were actually added.

(11-26-2012 04:04 PM)ZiNgA BuRgA Wrote: I question the use of bigint's in most database columns added, but I guess it really doesn't matter...

Would using int (not int(n)) be any better?

(11-26-2012 04:04 PM)ZiNgA BuRgA Wrote: Breaks if showthread is in threaded mode because $GLOBALS['pids'] isn't set

Bug. Who really uses threaded mode anyways ¬_¬

(11-26-2012 04:04 PM)ZiNgA BuRgA Wrote: I'd perform the first post check before running the query. I'm not entirely sure of the reason behind checking whether "$post['pid'] != $thread['firstpost']" as this will always be true if not on the first page of the thread.

Makes sense.

(11-26-2012 04:04 PM)ZiNgA BuRgA Wrote: Overwrites $lang var in a loop = broken behaviour

Bug.

Quote:On postbit, the plugin loads ALL votes, and does a summation + check for current user voting on this. This can potentially be problematic if there happens to be a large number of votes.

What do you suggest? I avoided to add a new column to the posts table since I hate doing so. If I understood correctly.

Quote:Can be defined in the CREATE TABLE statement (for examples, see install/resources/mysql_tables.php or whatever it's called).
Worthwhile reading a bit about MySQL's indexes: http://dev.mysql.com/doc/refman/5.5/en/c...index.html
In general, you just need to specify which columns you want in an index.

Do you think the following is correct?

SQL Code

	$db->write_query("CREATE TABLE `".TABLE_PREFIX."ougc_customrep_log` (
			`lid` int UNSIGNED NOT NULL AUTO_INCREMENT,
			`pid` int NOT NULL DEFAULT '0',
			`uid` int NOT NULL DEFAULT '0',
			`rid` int NOT NULL DEFAULT '0',
			`dateline` int(10) NOT NULL DEFAULT '0',
			PRIMARY KEY (`lid`),
			UNIQUE KEY piduid (pid,uid),
			CREATE INDEX pidrid (pid,rid)
		) ENGINE=MyISAM{$collation};"
	);

///---

	$db->write_query('ALTER TABLE '.TABLE_PREFIX.'ougc_customrep_log ADD UNIQUE KEY piduid (pid,uid)');
	if(!$db->index_exists('ougc_customrep_log', 'pidrid'))
	{
		$db->write_query('CREATE INDEX pidrid ON '.TABLE_PREFIX.'ougc_customrep_log (pid,rid)');
	}

Quote:Ah I see. You may wish to put that it's a +1/0/-1 (since reputations can have different weights). Also I suppose that changing the type won't update existing reputations?

The idea was to add a text box later so that it was not limited to just -1, 0, or +1.

Quote:Rating interface does not work with Javascript disabled (seems like a bug as opposed to intentional behaviour). Interestingly, turning off the AJAX setting makes it fail to work as well, regardless of whether Javascript is enabled or not

Quote:How to use the rating interface isn't obvious in any way - you've got an icon, then a "x [number]"; not only is this difficult to see that it's meant to be clicked on, the fact that the icon and number links and their respective functions isn't obvious. You can toggle the rating you've chosen by clicking on the icon, although this isn't exactly obvious either (there's no visual indication (not even in a tooltip) on whether clicking the icon will add to the reputation or remove from it).

I see what you mean there, it is everything but obvious. I assumed that since it was obvious to me (the one coding it), it would be to anyone.

Quote:Note that, however, you can't change your rating by clicking on another icon - you need to 'unrate' the post by clicking on the rating you originally specified (and this can be difficult to tell since there's no visual indication) and then click the other rating.

Nice idea, never though of such a thing.

Quote:set_url() isn't being called. Though that doesn't seem to be the only issue.

Seems to be working fine in my latest build, thanks!

Seems like this is full of bugs, I also noticed that moderation actions weren't being taken into consideration while coding it so some data may be not deleted when it should/is no necessary anymore.

Threaded Mode \| Linear Mode OUGC Custom Reputation
Please note that this is pretty much a negative criticism post, rather than a balanced review as mentioned in this thread. Also be aware that stuff posted here may be highly subjective. Please feel free to criticise this post, however. Plugin Reviewed: OUGC Custom Reputation Plugin Version: 1.0.1 (last updated 25th November 2012) Plugin Author: Omar G.
Author	Message