Show Referrals in Profile Review

[Sama34]

I would like to suggest some things.

• You should consider loading the language file only when necessary.
• Instead of:
  
  PHP Code:

  $referrer = (int)$mybb->input['uid']; $query = $db->simple_select("users", "uid,username,usergroup,displaygroup,avatar,avatardimensions,referrer,referrals" , "referrer = '$referrer'");

  ---

  
  You could just do:
  

  PHP Code:

  $referrer = (int)$memprofile['uid']; $query = $db->simple_select("users", "uid,username,usergroup,displaygroup,avatar,avatardimensions,referrer,referrals" , "referrer = '$referrer'");

  ---

  
  Which is more reliable.

• Instead of:
  
  PHP Code:

  1 2 3 4 5 6

  $referrer = htmlspecialchars($user['referrer']); //Fetch Referrer uid $query = $db->simple_select("users", "uid,username" , "username = '".$db->escape_string($referrer)."'"); $refers = $db->fetch_array($query);

  ---

  
  You could just do:
  

  PHP Code:

  //Fetch Referrer uid $query = $db->simple_select("users", "uid,username" , "uid = '".(int)$GLOBALS['userhandler']->data['referrer_uid']."'"); $refers = $db->fetch_array($query);

  ---

  
  Ideally and if using 1.8:
  

  PHP Code:

  //Fetch Referrer uid $refers = get_user_by_username($user['referrer']/*, array('fields' => array('username'))*/); // You don't really make use of the username.

  ---

  
  Even better you should be rather be hooking at datahandler_user_insert in whether 1.6 or 1.8

• Instead of:
  
  PHP Code:

  $newblink = '[url='.$mybb->settings['bburl'].'/member.php?action=profile&uid='.$new_uid.']'.$new_user.'[/url]';

  ---

  
  You should be using:
  

  PHP Code:

  $newblink = '[url='.$mybb->settings['bburl'].'/'.get_profile_link($new_uid).']'.$new_user.'[/url]';

  ---

• Ideally you should be using send_pm() instead in 1.8.
  

Most of those could not make any difference in your board where, IIRC, yo do not use SEF urls and users with small boards will probably not even notice/care for the others  but since you are releasing this to the public I felt just like sharing my thoughts.