Thread Rating:
  • 1 Votes - 4 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Show Referrals in Profile Review

Please note that this is pretty much a negative criticism post, rather than a balanced review as mentioned in this thread. Also be aware that stuff posted here may be highly subjective.
Please feel free to criticise this post, however.

Plugin Reviewed: Show Referrals in Profile
Plugin Version: 1.2 (last updated 3rd September 2015)
Plugin Author: LeeFish
Author Message
Sama34 Offline
Senior Member
****
Posts: 490
Joined: May 2011
Post: #6
RE: Show Referrals in Profile Review
First point kinda yep. You will probably waste more time moving the line that somebody else caring about its position.

In my second point _(int)$mybb->input['uid']_ may not be set if for example users visit:
http://mybbhacks.zingaburga.com/member.p...http://mybbhacks.zingaburga.com/member.php?acti

Third point is about the correct code and hook to use to make your plugin more friendly (using the correct hook on case, somehow, an user is created outside the registration page and a referrer is set, for example) and use less code.

Fourth point will probably not make a difference if you use Google SEO but core SEFs are.. different:
http://community.mybb.com/member.php?act...http://community.mybb.com/member.php?action=profile

Pretty sure somebody will complain eventually for this.

Lastly, send_pm() is just about using less code and it also helps you if you want to send the message in the user's language instead of the board default.

I wouldn't just call them "preference" but "experience" I have obtained from writing a bunch of free and private plugins, simple and extensive ones equally.

Support PM's will be ignored. Yipi
Plugins: Announcement Bars - Custom Reputation - Mark PM As Unread
10-02-2015 06:14 AM
Visit this user's website Find all posts by this user Quote this message in a reply


Messages In This Thread
RE: Show Referrals in Profile Review - Sama34 - 10-02-2015 06:14 AM

Forum Jump: