Cool Codes (Syntax Highlighter)

ZiNgA BuRgA · (This post was last modified: 02-28-2021 08:45 PM by ZiNgA BuRgA.)

This plugin is problematic under PHP 7.x or newer.

This is pretty much a MyBB 1.4/1.6 port of my Syntax Highlighter for MyBB 1.2.
I've also added line numbers to this one.

To resolve speed issues, you may be interested in my preparser cache plugin.

See the following thread for examples of what this looks like: http://mybbhacks.zingaburga.com/showthread.php?tid=33 (note, no code edits required for this version of the plugin)

***ZiNgA BuRgA*** · 12-16-2010 10:38 AM

Funny, none of those files changed it seems. Why would it come up now?
And also, PHP is seriously bizarre. It typically ignores additional parameters, (possibly for func_get_args), but it doesn't with ob_end_flush

PHP Code:

ob_end_flush(1); //warning
flush(1); //okay
ob_end_clean(1); //warning

Anyway, thanks for reporting - see v1.23 works for you.

Pirata Nervo · 12-16-2010 10:29 PM

No errors anymore. However, it seems that it's not parsing it correctly:
http://forums.consoleaddicted.com/Thread-C-C-Snippets

Any idea why? Another thing I've just noticed is that this error shouldn't even happen since I was not viewing the thread above in archive mode. There are not other plugins that make use of ob_end_flush() (at least I've searched all plugins and the only entries were inside the Cool Codes plugin - and I got an error whenever I visited the thread above - no longer though).

***ZiNgA BuRgA*** · 12-17-2010 09:32 AM

That's weird.

When I get home, I'll install a copy of 1.6.1 and see if I can figure it out.

Hmm, it seems that $parser->options has now become public:
http://dev.mybb.com/projects/mybb/reposi...http://dev.mybb.com/projects/mybb/repository/entry/branches/1.6-stable/inc/class_

That'll probably cause an issue for the workaround I made when it was private:

PHP Code:

                if($GLOBALS['mybb']->version_code >= 1500) {
                        $p = (array)$parser;
                        $opts =& $p["\0postParser\0options"];
                } else
                        $opts =& $parser->options;

Maybe change the above to:

PHP Code:

                if($GLOBALS['mybb']->version_code >= 1500 && $GLOBALS['mybb']->version_code <= 1600) {
                        $p = (array)$parser;
                        $opts =& $p["\0postParser\0options"];
                } else
                        $opts =& $parser->options;

Pirata Nervo · 12-18-2010 04:15 AM

Yeap that should fix it.

By the way, just in case you may want to look:
http://dev.mybb.com/projects/mybb/reposi...http://dev.mybb.com/projects/mybb/repository/revisions/5179/diff/branches/1.6-stable/inc/class_
http://dev.mybb.com/issues/1148

Actually it doesn't.

Code:

Warning [2] preg_match_all() expects parameter 2 to be string, array given - Line: 515 - File: inc/class_parser.php PHP 5.2.14 (Linux)

/inc/class_parser.php 	515 	preg_match_all
/inc/plugins/coolcode.php 	49 	postParser->parse_badwords
[PHP] 	  	coolcode_start
/inc/class_plugins.php 	101 	call_user_func_array
/inc/class_parser.php 	100 	pluginSystem->run_hooks
/inc/functions_post.php 	570 	postParser->parse_message
/showthread.php 	949 	build_postbit

***ZiNgA BuRgA*** · 12-18-2010 09:10 AM

Alright, can you try v1.24?
Thanks.

Pirata Nervo · 12-19-2010 01:28 AM

Will try it once I manage to get FTP working on my new VPS box.

Pirata Nervo · 12-19-2010 03:21 AM

Works

What was the problem?

***ZiNgA BuRgA*** · 12-19-2010 11:22 AM

(12-19-2010 01:28 AM)Pirata Nervo Wrote: Will try it once I manage to get FTP working on my new VPS box.

You can just use SFTP instead. FTP just increases the attack vectors on your box...

(12-19-2010 03:21 AM)Pirata Nervo Wrote: Works What was the problem?

Some bad code I think. You can do a diff if you're interested.

Pirata Nervo · 12-19-2010 08:34 PM

(12-19-2010 11:22 AM)ZiNgA BuRgA Wrote:
(12-19-2010 01:28 AM)Pirata Nervo Wrote: Will try it once I manage to get FTP working on my new VPS box.
You can just use SFTP instead. FTP just increases the attack vectors on your box...

(12-19-2010 03:21 AM)Pirata Nervo Wrote: Works What was the problem?
Some bad code I think. You can do a diff if you're interested.

Yeah I had to switch to SFTP, we are using proFTPD and FTP is kinda buggy there. The CEO of the company tried to install pureFTPD with DA but it had many problems during the installation and I agreed to install proFTPD again, so we're using SFTP now, no problems Tongue

How can I download an earlier version to do a diff?

***ZiNgA BuRgA*** · 12-20-2010 08:05 AM

Dunno, I'm lazy and don't keep earlier versions myself.
Just a small bug with calling parse badwords from memory anyway.

Cool Codes (Syntax Highlighter)
Author	Message