Anyone with IE willing to test this out for me?

[ZiNgA BuRgA]

IE6 in my VM refuses to accept cookies for some reason, and the IE7/IE8 installs just fail.  Have tried MS fixits, but still refuse to work, so I can't be bothered trying to get IE working at the moment.

I've made changes to the file input HTML/JS, in particular, the addition of multiple value file inputs, and want to see whether they work on IE.
If someone has a working copy of any version of IE from 6 onwards, and a test board they're willing to test the following with, it would be appreciated.
Chrome/Firefox/Opera seem to all work, so if you're interested in intentional behaviour, you can check with those browsers.

You can grab the code from the Github Dev branch, or from the attachment below.
After installing, you'll need to create 4 file input thread fields - 2 of these should accept multiple values, the other 2 shouldn't.  Leave the other options default (for the multi-valued fields, you'll need to supply a delimiter - use whatever you want).  After that, go to a new thread page, and test the following:

• Check that you can select a file for each of the fields, and then the Clear button successfully resets the field
• When you select a file in the multi-valued fields, it should automatically add a new input below the current one
• Refresh the page, then for one of the multi-valued fields, add a file - this should create an empty input below it.  Clear the file you just added, then reselect a file in the same (first) input - this shouldn't create any new input.  Click the Clear button on the second input, then select a file, confirming that it creates a third input underneath.
• For a single file input, select a file, then switch to the URL option, then switch back to File - the input should be cleared.  Now select another file, click the Clear button, then select a file again, and switch to URL -> File to ensure that this clearing behaviour hasn't been messed up by the Clear button.
• Clear any files (or refresh page), then attach 2 or more files to the multi-valued inputs, and a file to one of the single-value inputs, then click Preview post.  If everything uploaded successfully, check that you can reorder the files in the multi-valued inputs by dragging them around.  Ticking the Remove checkbox should cause the file to be crossed out.  Also the layout of the files in the multi-valued inputs should look reasonable.  Lastly, try rearranging the files, hitting Preview post and confirming that the ordering is as you left it.
  

If you do do any of the above, I would appreciate if you would post the feedback, including what you tried, what worked/didn't, anything else and the version of IE you tested on.
Thanks!

[RateU]

Whoa, multi file uploads! Great!

This is my testing result, Yumi (I use a fresh MyBB 1.8 installation):

• Settings for multiple value file inputs:
  • Input Field Type: File
  • Allow multiple values for this field: Yes
  • Multiple Value Delimiter:
    Code:

     

    ---

  • Title:
    • The first multiple file input: Multi File 1
    • The second multiple file input: Multi File 2
      
  • Key:
    • The first multiple file input: mf1
    • The second multiple file input: mf2
      
  • Display Order:
    • The first multiple file input: 1
    • The second multiple file input: 2
      
  • The other settings is default (I don't change anything)
    
• Settings for single file inputs:
  • Input Field Type: File
  • Title:
    • The first single file input: Single File 1
    • The second single file input: Single File 2
      
  • Key:
    • The first single file input: sf1
    • The second single file input: sf2
      
  • Display Order:
    • The first single file input: 3
    • The second single file input: 4
      
  • The other settings is default (I don't change anything)
    
• Manual edit for newthread template (before the </head> tag). I need to do this manually because by default, the Clear buttons won't be displayed, and I can't drag and drop the uploaded files. So based on the Input Field HTML codes, I add the code manually (to test it out).
  
  HTML Code

  6 7	<script type="text/javascript" src="{$mybb->settings['bburl']}/jscripts/scriptaculous.js?load=effects,dragdrop"></script> <script type="text/javascript" src="{$mybb->settings['bburl']}/jscripts/xthreads_attach_input.js"></script>

  ---

  Full newthread template:
  

  HTML Code

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59

  <html> <head> <title>{$lang->newthread_in}</title> {$headerinclude} <script type="text/javascript" src="jscripts/post.js?ver=1400"></script> <script type="text/javascript" src="{$mybb->settings['bburl']}/jscripts/scriptaculous.js?load=effects,dragdrop"></script> <script type="text/javascript" src="{$mybb->settings['bburl']}/jscripts/xthreads_attach_input.js"></script> </head> <body> {$header} {$preview} {$thread_errors} {$attacherror} <form action="newthread.php?fid={$fid}&amp;processed=1" method="post" enctype="multipart/form-data" name="input"> <input type="hidden" name="my_post_key" value="{$mybb->post_code}" /> <table border="0" cellspacing="{$theme['borderwidth']}" cellpadding="{$theme['tablespace']}" class="tborder"> <tr> <td class="thead" colspan="2"><strong>{$lang->post_new_thread}</strong></td> </tr> {$loginbox} <tr> <td class="trow2" width="20%"><strong>{$lang->thread_subject}</strong></td> <td class="trow2">{$prefixselect}<input type="text" class="textbox" name="subject" size="40" maxlength="85" value="{$subject}" tabindex="1" /></td> </tr> {$extra_threadfields}{$posticons} <tr> <td class="trow2" valign="top"><strong>{$lang->your_message}</strong>{$smilieinserter}</td> <td class="trow2"> <textarea name="message" id="message" rows="20" cols="70" tabindex="2">{$message}</textarea> {$codebuttons} {$multiquote_external} </td> </tr> <tr> <td class="trow1" valign="top"><strong>{$lang->post_options}</strong></td> <td class="trow1"><span class="smalltext"> <label><input type="checkbox" class="checkbox" name="postoptions[signature]" value="1" tabindex="7"{$postoptionschecked['signature']} /> {$lang->options_sig}</label> {$disablesmilies}</span></td> </tr> {$modoptions} {$subscriptionmethod} {$pollbox} {$captcha} </table> {$attachbox} <br /> <div style="text-align:center"><input type="submit" class="button" name="submit" value="{$lang->post_thread}" tabindex="4" accesskey="s" /> <input type="submit" class="button" name="previewpost" value="{$lang->preview_post}" tabindex="5" />{$savedraftbutton}</div> <input type="hidden" name="action" value="do_newthread" /> <input type="hidden" name="posthash" value="{$posthash}" /> <input type="hidden" name="attachmentaid" value="" /> <input type="hidden" name="attachmentact" value="" /> <input type="hidden" name="quoted_ids" value="{$quoted_ids}" /> <input type="hidden" name="tid" value="{$tid}" /> {$editdraftpid} </form> {$forumrules} {$footer} </body> </html>

  ---

This is the newthread display (I use FF to grab the screenshot):
   
I don't know how to display the options (File and URL) for the single file inputs, Yumi?

Testing using:

• IE 6 (Win XP):
  • When adding a file into one of the multi value file input, it doesn't create a new empty file input below it.
       
  • The Clear button doesn't reset the file input.
  • To test the drag and drop function, I select a file, then hit the Preview button. I do this for several times. All of files uploaded successfully.
       
  • Unfortunately, I can't drag and drop the uploaded files.
  • Checking and unchecking the Remove checkboxes works.
       
    

• Firefox 10.0.2 (Win XP):
  
  Well, testing with Firefox is great! An empty new file input will be added automatically when adding a file into the multi value file input. We can drag and drop the uploaded files, and the new files order works correctly when hitting the Preview button. And the Remove checkboxes work.
  

I would like to ask this behaviour, Yumi (I don't know whether this is an intentional or not):

• Click the Clear button first, then browse a file. It won't create a new empty file input?
• Upload several files, and hit the Preview button. The files uploaded successfully.
     
  Then, click one or several of the Remove checkboxes:
     
  • Additional report: at this step, if I upload a new file using that file input, then hit the Preview button, I get: Fatal error: Cannot unset string offsets in .....\inc\xthreads\xt_updatehooks.php on line 1027. Only happens if there is a checked Remove checkbox.
    
  then hit the Preview button again. All of the chekboxes checked?
     
  This happens in FF and IE 6.
  

Thank you very much, Yumi

[ZiNgA BuRgA]

Wow, thanks a lot RateU for all that.
I'll need to look through it later.

Though I am interested in why the Javascript didn't auto-insert for you...  If you still have it for that board, could you post your cache/xthreads_evalcache.php please?

[RateU]

(06-22-2012 05:09 AM)RateU Wrote:  I use a fresh MyBB 1.8 installation

Ooops. I'm sorry, I mean MyBB 1.6.8

(06-22-2012 09:16 PM)ZiNgA BuRgA Wrote:  Though I am interested in why the Javascript didn't auto-insert for you...  If you still have it for that board, could you post your cache/xthreads_evalcache.php please?

Yes, Yumi. I don't know why it doesn't insert the javascript. I've tried setting the Use Custom Input HTML to Yes, but still, the Clear button is not displayed. The same as the Single File Input, I've tried setting the Custom Input HTML to Yes, but still, the Option buttons (File and URL) is not displayed.
Viewing my source page, there is no javascript tags there (the scriptaculous.js and the xthreads_attach_input.js).

My xthreads_evalcache.php is attached.
I use my localhost:
PHP Version: 5.3.8
SQL Engine: MySQLi 5.5.16

this is my threadfields cache:

Code:

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135

Array ( [mf1] => Array ( [field] => mf1 [title] => Multi File 1 [forums] => 2 [editable] => 0 [editable_gids] => [viewable_gids] => [blankval] => [dispformat] => 1 [dispitemformat] => 1 [datatype] => 0 [inputvalidate] => [multival] =>   [desc] => [inputtype] => 5 [disporder] => 1 [tabstop] => 1 [hideedit] => 0 [formhtml] => [fieldwidth] => 40 [filemagic] => [fileexts] => [filemaxsize] => 0 [fileimage] => [formatmap] => [vallist] => [editable_values] => [inputformat] => [unviewableval] => [formhtml_item] => ) [mf2] => Array ( [field] => mf2 [title] => Multi File 2 [forums] => 2 [editable] => 0 [editable_gids] => [viewable_gids] => [blankval] => [dispformat] => 1 [dispitemformat] => 1 [datatype] => 0 [inputvalidate] => [multival] =>   [desc] => [inputtype] => 5 [disporder] => 2 [tabstop] => 1 [hideedit] => 0 [formhtml] => [fieldwidth] => 40 [filemagic] => [fileexts] => [filemaxsize] => 0 [fileimage] => [formatmap] => [vallist] => [editable_values] => [inputformat] => [unviewableval] => [formhtml_item] => ) [sf1] => Array ( [field] => sf1 [title] => Single File 1 [forums] => 2 [editable] => 0 [editable_gids] => [viewable_gids] => [blankval] => [dispformat] => 1 [datatype] => 0 [inputvalidate] => [multival] => [desc] => [inputtype] => 5 [disporder] => 3 [tabstop] => 1 [hideedit] => 0 [formhtml] => [fieldwidth] => 40 [filemagic] => [fileexts] => [filemaxsize] => 0 [fileimage] => [formatmap] => [vallist] => [editable_values] => [inputformat] => [unviewableval] => [dispitemformat] => [formhtml_item] => ) [sf2] => Array ( [field] => sf2 [title] => Single File 2 [forums] => 2 [editable] => 0 [editable_gids] => [viewable_gids] => [blankval] => [dispformat] => 1 [datatype] => 0 [inputvalidate] => [multival] => [desc] => [inputtype] => 5 [disporder] => 4 [tabstop] => 1 [hideedit] => 0 [formhtml] => [fieldwidth] => 40 [filemagic] => [fileexts] => [filemaxsize] => 0 [fileimage] => [formatmap] => [vallist] => [editable_values] => [inputformat] => [unviewableval] => [dispitemformat] => [formhtml_item] => ) )

---

This is how I did the testing:
1. Install MyBB 1.6.8
2. Install the XThreads dev version (without installing the official XThreads 1.53 version first).

Thanks, Yumi.

[ZiNgA BuRgA]

Gah, I messed up some conditional code.
Thanks for all your testing RateU!

Everything should be fixed now

[RateU]

Yeah, that also works with IE 6! I like the Custom Modify Error feature too, Yumi (I know that it is still in development phase, but I have no patience to test it)

[ZiNgA BuRgA]

That feature's pretty much finished.  Haven't tested it with multi-file fields yet, though I don't expect any issues, so yeah, post about it if there's any issues with it!

[RateU]

I would like to ask this question about the feature, Yumi:
How to use the {NUM_FILES} variable there (in multi file input type)?
Each time I put the variable, Bad Conditional Syntax Detector detects that there is a bad conditional syntax in that setting:

The following errors were encountered: Wrote:Bad conditional syntax detected for Custom Modify Error.

This is the conditional I use:

Code:

<if intval({NUM_FILES}) > 5 then>Max file is 5</if>

---

I use a fresh MyBB 1.6.8 installation, and the XThreads file name is:
zingaburga-XThreads-MyBB-Plugin-v1.53-28-g3cd3146

[ZiNgA BuRgA]

That may be because I forgot to add it, lol.
Ta for pointing out.

[Glas]

If you still need a tester i can do this weekend, i have exams this friday =(