Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
OUGC Max Sign Images

Please note that this is pretty much a negative criticism post, rather than a balanced review as mentioned in this thread. Also be aware that stuff posted here may be highly subjective.
Please feel free to criticise this post, however.

Plugin Reviewed: OUGC Max Sign Images in Group Basis
Plugin Version: 1.0 (last updated 10th March 2012)
Plugin Author: Omar G.
Author Message
ZiNgA BuRgA Offline
Fag
*******
Posts: 3,338
Joined: Jan 2008
Post: #1
OUGC Max Sign Images
This is a plugin "review" requested by Sama34.

A very simple plugin that merely re-uses MyBB's functionality, applying it to different groups, and it's made pretty much how I'd do it.

Probably the only things I'd mention:
  • I would've liked an intval of sorts here, although it's the ACP, and probably not that necessary

    PHP Code:
    	$updated_group = array_merge($updated_group, array("maxsigimages" => intval($mybb->input['maxsigimages'])));

  • It probably should be mentioned in the description that setting a value of -1 implies "unlimited" images allowed in the signature.

My Blog
03-25-2012 09:19 PM
Find all posts by this user Quote this message in a reply
Sama34 Offline
Senior Member
****
Posts: 476
Joined: May 2011
Post: #2
RE: OUGC Max Sign Images
Thanks, I added the intval() there so it could be more secure, although yes, since they are in the ACP, they can do more damage from anywhere else that trow this field.

Once more, thanks for the review.

Support PM's will be ignored. Yipi
Plugins: Announcement Bars - Custom Reputation - Mark PM As Unread
03-30-2012 12:53 PM
Visit this user's website Find all posts by this user Quote this message in a reply


Forum Jump: