Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
OUGC Mark PM As Unread

Please note that this is pretty much a negative criticism post, rather than a balanced review as mentioned in this thread. Also be aware that stuff posted here may be highly subjective.
Please feel free to criticise this post, however.

Plugin Reviewed: OUGC Mark PM As Unread
Plugin Version: 1.0
Plugin Author: Omar Gonzalez
Author Message
ZiNgA BuRgA Offline
Fag
*******
Posts: 3,357
Joined: Jan 2008
Post: #3
RE: OUGC Mark PM As Unread
(08-21-2012 05:12 AM)Sama34 Wrote:  Didn't know we could use @ to hide variable errors too (just functions). This should probably save code in future.
It's actually unnecessary because MyBB ignores notice errors, but I just chucked it there for the sake of doing so.

(08-21-2012 05:12 AM)Sama34 Wrote:  It is done that way so that the text is only show when necessary, I know nothing about regex, so I will be even more work to hide it using a different way (I like nice details too).
Okay, I missed that - my bad.
Still doable with a CSS hack, but I guess it's less elegant.

(08-21-2012 05:12 AM)Sama34 Wrote:  Probably can reduce the code there, but what exactly do you mean?

PHP Code:
1
2
3
4
5
6
7
8
9
10
11
12
if($mark = ougc_markpmasunread_markunread($mybb->input['markunread'])) {
	global $lang;
	$lang->load('ougc_markpmasunread');
	error($lang->$mark);
}

function ougc_markpmasunread_markunread(...) {
if(you_suck)
	return 'ougc_markpmasunread_error_invalidpm';
...
return false;
}


Doesn't handle the default case, but all return values from the function are controlled, right?


My Blog
08-21-2012 11:17 AM
Find all posts by this user Quote this message in a reply


Messages In This Thread
OUGC Mark PM As Unread - ZiNgA BuRgA - 08-18-2012, 11:10 PM
RE: OUGC Mark PM As Unread - Sama34 - 08-21-2012, 05:12 AM
RE: OUGC Mark PM As Unread - ZiNgA BuRgA - 08-21-2012 11:17 AM
RE: OUGC Mark PM As Unread - Sama34 - 08-21-2012, 01:57 PM

Forum Jump: