Preparser Cache
Author Message
This is a fairly simple pre-parser modification which should speed up one of MyBB's slowest functions.
Basically, MyBB's MyCode parser is rather slow; this plugin speeds this component up by caching the result so that the parser does not have to be run on every single page request (this is assuming that SHA1 hashing + a single query with some string manipulation is faster than running the parser 20+ times).

This plugin is compatible with all supported DB engines (SQLite in MyBB 1.6.0 is bugged, so cannot be tested).

Compatibility with other plugins
Due to the fact that this modification changes the environment under which the parser is run, I cannot guarantee that this will work with all MyCode/HTML or parser related plugins, especially those that may display posts differently to different users (on the other hand, this actually may have the potential to remove some of the issues in some poorly coded modifications).  Custom MyCodes should still work, and there is a workaround for the vB Quote plugin.
This will not work with the HTML in Posts plugin.

About design
The design of this is much simpler than my mod for MyBB 1.2, and as such, is nowhere near as aggressive, however, it's something I (originally!) banged up together in about an hour, and gets most of the benefits anyway.  It differs from both my 1.2 mod, and Ryan Gordon's 1.4 mod in that it operates at a parser level instead of at the showthread/postbit level.

The plugin only does posts and signatures on showthread.php, but it can be quite easily modified for other places, as it operates on a parser level.  Again, this was something I wrote fairly quickly, and could use a number of improvements in some areas.
The cache is periodically cleaned via a cleanup task.

Note
Note that this plugin also provides a way to manually clear the cache, under the Recount & Rebuild section of the AdminCP, should you ever have the need to do so.

Known Issues
  • Attachments embedded with the [attachment=id] code may not have their download count updated
  • A very minor one - it's possible to cause this plugin to display removed attachments embedded in the post (will be a dead link though).  Standard MyBB behavior will simply ignore the [attachment=id] code.  This will do the same if the post is updated in any way.
  • For MyBB 1.8, quote times will be forced to use absolute time (instead of relative).  For earlier versions, there is no change to the timestamp displayed, however the "Today" and "Yesterday" text will never get updated (until a cache clear), so this can be inaccurate if this occurs



Simple Benchmark
Just a simple benchmark I performed to get an idea of the speed gains of this plugin.  I'm benchmarking this page, with and without the plugin.  I guess the page is somewhat a good candidate for this plugin, although I didn't exactly cherry pick it on purpose.

Times were recorded by just using the time metric at the bottom of the page.  Note that the plugin does a number of things after the timer has completed, so I've also made a comparison after modifying MyBB's timer to more accurately measure the time (if you don't perform this modification, the preparser mod should pretty much always make your showthread pages seem to run faster).
Pages were loaded 3 times.

Standard behaviour: 0.2359838s, 0.2380810s, 0.2462718s
Standard behaviour, after editing timer: 0.2320759s, 0.2335730s, 0.2380040s
With preparser (with timer edit): 0.1327140s, 0.1319780s, 0.1258268s
With preparser (without timer edit (inaccurate)): 0.1291881s, 0.1186280s, 0.1211529s

Initial load with preparser, timer edit: 0.2454121s (this is the page load which caches everything - it'll be slower than normal page loads, but subsequent requests will be much faster)

1.0 benchmarks:
Standard behaviour: 0.2242870s, 0.2201211s, 0.2377510s
Standard behaviour, after editing timer: 0.2399340s, 0.2398720s, 0.2158720s
With preparser (with timer edit): 0.1303909s, 0.1500199s, 0.1303349s
With preparser (without timer edit (inaccurate)): 0.1157429s, 0.1143448s, 0.1083250s
(This post was last modified: 04-02-2017 10:23 PM by ZiNgA BuRgA.)
Find all posts by this user
Quote this message in a reply
Download: preparser-1.13.7z (4.52 KB)
Plugin Version: 1.13
Last Updated: 04-02-2017, 10:23 PM

Downloads: 1,487
MyBB Compatibility: 1.4.x, 1.6.x, 1.8.x
Plugin License: WTFPLv2
Uploader: ZiNgA BuRgA
ZiNgA BuRgA Offline
Fag
*******
Posts: 3,338
Joined: Jan 2008
Post: #11
RE: Preparser Cache
(10-11-2010 12:13 PM)ZiNgA BuRgA Wrote:  RateU pointed out that this plugin doesn't handle [attachment=] style tags properly.

Unfortunately, I don't see a good way of resolving this, considering how this plugin was designed, so I'll probably need to re-create it in a completely different way.
Sorry about that.
Scrap that, I figured out a bit of a dirty workaround for this.

Updated to v1.1 to fix the [attachment=...] parsing issue.  The workaround slows the plugin down slightly, but it's still significantly faster than default MyBB behaviour (see updated benchmarks in first post).
Also, this plugin will now work on SQLite/PostgreSQL (as long as MyBB fully supports them).

My Blog
(This post was last modified: 11-11-2010 10:02 PM by ZiNgA BuRgA.)
11-11-2010 10:02 PM
Find all posts by this user Quote this message in a reply
leefish Offline
Hamster
*******
Posts: 1,009
Joined: Apr 2010
Post: #12
RE: Preparser Cache
Thank you Zinga, I have installed, seems ok with my attachments Smile


[Image: leelink.gif]
MYBB1.6 & XThreads
11-12-2010 01:41 AM
Visit this user's website Find all posts by this user Quote this message in a reply
RateU Offline
Administrator
*******
Posts: 2,327
Joined: Mar 2010
Post: #13
RE: Preparser Cache
Thanks for the update, Yumi Smile

11-12-2010 07:11 AM
Find all posts by this user Quote this message in a reply
Firefox Wins Offline
Member
***
Posts: 164
Joined: Mar 2008
Post: #14
RE: Preparser Cache
Downloading now, thank you.
It's Alive!!!
11-12-2010 02:17 PM
Find all posts by this user Quote this message in a reply
ZiNgA BuRgA Offline
Fag
*******
Posts: 3,338
Joined: Jan 2008
Post: #15
RE: Preparser Cache
Thanks to RateU for discovering a small glitch in the plugin, with "$1" in posts being hidden.
This has been resolved in v1.11.

Note that you may have to clear the parser cache (ACP -> Tools -> Recount & Rebuild) if you are already experiencing this issue.

My Blog
11-20-2010 08:04 AM
Find all posts by this user Quote this message in a reply
ZiNgA BuRgA Offline
Fag
*******
Posts: 3,338
Joined: Jan 2008
Post: #16
RE: Preparser Cache
It seems that there's still a few problems with attachments inserted into posts via [attachment] code:
- the downloads count may not update
- there may be an issue with unapproved attachments and visibility of them depending on what is cached

I'm thinking that fixing these may require a bit of a redesign...

My Blog
02-15-2011 09:33 AM
Find all posts by this user Quote this message in a reply
leefish Offline
Hamster
*******
Posts: 1,009
Joined: Apr 2010
Post: #17
RE: Preparser Cache
I have been using Tomm's usertagging plugin from MyNetwork, and it seems there is a conflict with the pre_parser plugin.

When I first submit the tag it works fine, but on page refresh, or returning to the page the tag has been changed from

@user to <-- @username -->

The plugin is here:  http://resources.xekko.co.uk/mynetwork/f...gging.html

I have reported this to Tomm. The forum I tested on has no special features, and when I deactivated the pre_parser plugin the tagging worked.


[Image: leelink.gif]
MYBB1.6 & XThreads
(This post was last modified: 05-10-2011 11:54 PM by leefish.)
05-10-2011 11:53 PM
Visit this user's website Find all posts by this user Quote this message in a reply
ZiNgA BuRgA Offline
Fag
*******
Posts: 3,338
Joined: Jan 2008
Post: #18
RE: Preparser Cache
I think the design of the preparser ultimately will just conflict unfortunately.  And I don't think there's really a nice solution.

I'll probably need to redesign this to fix that.  Initially, I chose to design this at a parser level because it was different, quick to do, and potentially more flexible.  But it seems that it'll have issues with various modifications >_>

My Blog
05-11-2011 12:00 PM
Find all posts by this user Quote this message in a reply
leefish Offline
Hamster
*******
Posts: 1,009
Joined: Apr 2010
Post: #19
RE: Preparser Cache
Yes, I thought it would be a bugger to solve, it was more of a heads-up really. Thanks for the reply Smile


[Image: leelink.gif]
MYBB1.6 & XThreads
05-11-2011 01:49 PM
Visit this user's website Find all posts by this user Quote this message in a reply
sledgeab Offline
Junior Member
**
Posts: 1
Joined: Jun 2010
Post: #20
RE: Preparser Cache
signature links have problems. What can I do?
05-15-2011 02:47 AM
Find all posts by this user Quote this message in a reply


Forum Jump: