Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Tagging Plugin v1.2.2 Review

Please note that this is pretty much a negative criticism post, rather than a balanced review as mentioned in this thread. Also be aware that stuff posted here may be highly subjective.
Please feel free to criticise this post, however.

Plugin Reviewed: Tagging Plugin!
Plugin Version: 1.2.2 (last updated 1st May 2010)
Plugin Author: flash.tato
Author Message
ZiNgA BuRgA Offline
Fag
*******
Posts: 3,357
Joined: Jan 2008
Post: #9
RE: Tagging Plugin v1.2.2 Review
Just their way of doing things.
If you go around their dev site, you'll see that they will often try to avoid changes.
They accept a lot of bad coding practices and generally don't fix them, such as

PHP Code:
1
2
3
4
5
6
7
8
9
		switch($db->type)
		{
			case "pgsql":
			case "sqlite":
				$query = $db->simple_select("modtools", 'tid, name', "(','||forums||',' LIKE '%,$fid,%' OR ','||forums||',' LIKE '%,-1,%' OR forums='') AND type = 't'");
				break;
			default:
				$query = $db->simple_select("modtools", 'tid, name', "(CONCAT(',',forums,',') LIKE '%,$fid,%' OR CONCAT(',',forums,',') LIKE '%,-1,%' OR forums='') AND type = 't'");
		}

which you may find littered around the place.  The code goes against the whole purpose of a DB abstraction layer, but that's how things are.

Ultimately, it may not be a bad strategy.  The majority of forum admins don't understand good coding practices, and if you spend more time developing features and less on good code (as long as it is "good enough"), you get the attention.


My Blog
11-24-2010 09:31 AM
Find all posts by this user Quote this message in a reply


Messages In This Thread
Tagging Plugin v1.2.2 Review - ZiNgA BuRgA - 11-22-2010, 02:28 PM
RE: Tagging Plugin v1.2.2 Review - Imran - 11-22-2010, 06:30 PM
RE: Tagging Plugin v1.2.2 Review - Skiilz - 11-23-2010, 05:34 AM
RE: Tagging Plugin v1.2.2 Review - ZiNgA BuRgA - 11-24-2010 09:31 AM

Forum Jump: