MyBB Hacks

(03-07-2011 05:38 PM)ZiNgA BuRgA Wrote: [ -> ]Sorry about that.  Yes, outside the conditional.  In 1.4, there is no such conditional.

Hope that helps.

Works like a charm!  Thanks for a great plugin!

Found a bug, I think.

I get the following error when attempting to Approve a new thread requiring moderation.  It does indeed approve the thread and make it visible to all users, but the moderator count shows an unapproved thread in the forum's thread count IE "8 (1)" until a recount & rebuild is done on Forum Counters.

Quote:MyBB has experienced an internal SQL error and cannot continue.

SQL Error:
1064 - You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1
Query:
UPDATE ovabb_threads SET deleted=0, deletedposts=deletedposts-1 WHERE tid IN ()

Thanks - would you be able to test if v1.25 fixes it?

Thanks for the quick fix.  Yes.  v1.25 fixes it.

Something else I've run across, if a user creates a draft in a thread that is subsequently deleted, the draft stays in the Drafts folder under User CP.

They are unable to either open or delete the draft.  It's stuck listed there.

Thanks for all the reports and sorry for all the trouble caused.
If I'm understanding you correctly, this is probably a MyBB issue.
Example: create a new thread, then make a draft reply in this thread as a non-moderator user.  Then unapprove this thread and you'll get this problem from the user's perspective.
(if you're wondering, this Soft Delete plugin somewhat reuses MyBB's unapprove functionality)

Purging the deleted thread will remove the "ghost" draft post.

Hope that helps - it might be better to report this to MyBB development.

Ah yes.  You are correct.  I was aware of the reliance on approve/disapprove as part of the functionality, but did not consider that would be the problem.

No trouble at all!  I appreciate that you do this in your own time for free.  I try to make a habit of reporting things as I come across them for everybody's benefit.

Thanks again!

I think that if you do somthing like that: "This message was deleted by X" it would be nice, just like in vBulletin.
In addition, the option to add a reason for deletion will be excellent!
Thanks =]
(Sorry about my bad english...)

I've noticed a small but annoying bug. If you have the plugin "Undo-Delete" by Sebastian Wunderlich and you delete a post a restore it using your mod and try to delete it again you get this error.

Quote:MyBB has experienced an internal SQL error and cannot continue.

SQL Error:
1062 - Duplicate entry '2386' for key 1
Query:
INSERT INTO mybb_backup_posts (`pid`,`tid`,`replyto`,`fid`,`subject`,`icon`,`uid`,`username`,`dateline`,`message`,`ipaddress`,`lon​gipaddress`,`includesig`,`smilieoff`,`edituid`,`edittime`,`visible`,`posthash`,`mobile`,`pthx`,`modn​otice`,`modedituid`,`modedittime`,`tags`,`deleted`) VALUES ('2386','333','2267','31','RE: We need more members!','0','2','GravityMyth','1286641451','Woah, only 50+ active members and you\'re planing on getting another mod already?\nI would suggest waiting, even if one of the mods (me >.> .....) aren\'t that active.','74.110.163.106','1248764778','1','0','0','0','1','9e043513e83cb1fe908e6e59afb39ea3','0','0','','0','0','','0')

Now you would need to go into the Undo-Delete plugin and remove the backup it made for that post to actually delete it again.

You might be able to do anything about it since the other plugin causes this issue but I though I let you know about it.

I don't think the two plugins are really designed to work with each other.  This one will stop a post being deleted, whereas the other will make a copy when it's deleted.  Obviously conflicting behaviour, and I don't see an obvious way to resolve it unfortunately.