MyBB Hacks

Full Version: XThreads
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
I don't think reinstalling will make a difference here.  It's likely either something Javascript related on the edit page, or something is messing up with the hooking or save routine for custom mod tools.

If you want to try debugging it, try looking at the xthreads_admin_modtool_commit function in inc/xthreads/xt_admin.php
The function basically takes the input and puts it into the database - something's probably breaking there.

Thanks for the info BTW.
You'll have to forgive me for some conjecture here (I'm not on my dev machine, nor will I be able to for the next day or so) but it looks to me that, at least in the version on GitHub, the function xthreads_admin_modtool_commit is trying to add to a field that doesn't exist (edit_threadfields --> I can't see this being added in the install function) in the modtools table. As I say I can't check my actual install because I'm not on that computer.
The modtools.threadoptions field is a serialized array of a number of things, including edit_threadfields, so it doesn't require a new field.
But thanks for taking a look anyway.
Hi, I have upgraded to 1.8.4 and when I try to open a thread I have error:

Quote:Fatal error: Declaration of _objcont_2::fetch_array() must be compatible with DB_Base::fetch_array($query, $resulttype = MYSQL_ASSOC) in /mysite/public/forum/inc/plugins/xthreads.php(881) : eval()'d code on line 25

How can I fix it? Frown

XTHREADS_VERSION 1.64 (I used that from development github)

The problem is only on showthreads with Xthreads things (I have 1 image, data of expiration, 2 links). I can look forumdisplays without problems, also if on forumdisplay I have always an Xthreads image, but I can't read showthreads.

EDIT: Probably it's a problem of "Show first post on every showthread page", I set it on "No" and at least showthread now I can look Biggrin
When i visit Who's Online i get this error.

Fatal error: Declaration of _objcont_1::fetch_array() must be compatible with DB_Base::fetch_array($query, $resulttype = 1) in /home/generalc/public_html/inc/plugins/xthreads.php(881) : eval()'d code on line 30

Plus this error when i visit the threads,

Fatal error: Declaration of _objcont_2::fetch_array() must be compatible with DB_Base::fetch_array($query, $resulttype = 1) in /home/generalc/public_html/inc/plugins/xthreads.php(881) : eval()'d code on line 25
Looks like an issue with one of the calls to control_object(). In MyBB 1.8, we added a second parameter to DB_MySQL::fetch_array() which adds a second parameter. The code hasn't been updated to reflect that change. In 1.8.4, all database classes implement an interface which enforces this contract.

I have opened a pull request for this change here: https://github.com/MyBBStuff/XThreads-My...https://github.com/MyBBStuff/XThreads-MyBB-Plu
Yep, missed that one. I'll modify my PR. I just did a find in files and didn't see that one appear in the results Frown

EDIT: Updated
Thanks for bug reports & fix!

Updated to v1.65:
  • fix fatal error when downloading xtattachments (thanks to Shemo for reporting)
  • fix forumdisplay sorter links when Google SEO URL is enabled and a threadfield filter is being used
  • fix compatibility problem with MyBB 1.8.4 (thanks to all who found the problem and helped with the fix)
  • add ability to get raw/unsanitized value of a thread field via $threadfields_x['...']['raw_value']
(02-18-2015 07:36 PM)ZiNgA BuRgA Wrote: [ -> ]Thanks for bug reports & fix!

Updated to v1.65:
  • fix fatal error when downloading xtattachments (thanks to Shemo for reporting)
  • fix forumdisplay sorter links when Google SEO URL is enabled and a threadfield filter is being used
  • fix compatibility problem with MyBB 1.8.4 (thanks to all who found the problem and helped with the fix)
  • add ability to get raw/unsanitized value of a thread field via $threadfields_x['...']['raw_value']

You are the best! Thanks a lot for the quick fix and everything is smooth and normal Yipi
Reference URL's